This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix 5247: No rounding if users want to send/swap full token balance #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…als and do not round if the user chooses full balance to send or swap.
StephenHeaps
approved these changes
Apr 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fetching token balance with all available decimals.
Displaying all decimals and no rounding if the user decides to send/swap full token balance.
Added unit tests.
This pull request fixes #5247
Submitter Checklist:
NSLocalizableString()Test Plan:
Simulator.Screen.Recording.-.iPhone.13.Pro.-.2022-04-13.at.11.26.17.mp4
Simulator.Screen.Recording.-.iPhone.13.Pro.-.2022-04-13.at.17.25.20.mov
Reviewer Checklist:
QA/(Yes|No)bug/enhancement