Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #4995: Don't show Brave News inline ads when there are no feed items #4997

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #4995

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Test regular feed, ensure ads and feed items are visible
  • Install fresh (required to reset ads cap), disable all sources, verify that no inline ads appear
  • Add a source that results in more than 10 feed items and verify ads and feed items are visible

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team February 17, 2022 17:31
@kylehickinson kylehickinson added this to the 1.36 milestone Feb 17, 2022
@kylehickinson kylehickinson merged commit 05151f3 into development Feb 17, 2022
@kylehickinson kylehickinson deleted the empty-feed-ads branch February 17, 2022 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling all sources shows Brave Inline Ads but restart removes it
2 participants