This repository has been archived by the owner on May 10, 2024. It is now read-only.
Guard iOS 14.3 and up to be sandboxed. iOS 14.2 and below has a WebKit Crash #4968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
"Fatal error: Bug in WebKit: Received neither result or failure.: file WebKit/WebKitSwiftOverlay.swift, line 66"
This pull request fixes #4967
Submitter Checklist:
NSLocalizableString()
Test Plan:
It can be tested as a part of manual passes:
javascript:alert("hello");
This exact crash we are fixing happens on iOS 14.2 or lower devices. QA most likely does not have such device,
we tested it on our own locally with simulator builds.
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement