Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Guard iOS 14.3 and up to be sandboxed. iOS 14.2 and below has a WebKit Crash #4968

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Feb 9, 2022

Summary of Changes

  • Guard iOS 14.3 and up to be sandboxed.
  • iOS 14.2 and below has a crash: "Fatal error: Bug in WebKit: Received neither result or failure.: file WebKit/WebKitSwiftOverlay.swift, line 66"

This pull request fixes #4967

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

It can be tested as a part of manual passes:

  • Test session restore
  • Test reader-mode
  • Test playlist
  • Test a bookmarklet like: javascript:alert("hello");

This exact crash we are fixing happens on iOS 14.2 or lower devices. QA most likely does not have such device,
we tested it on our own locally with simulator builds.

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

…: "Fatal error: Bug in WebKit: Received neither result or failure.: file WebKit/WebKitSwiftOverlay.swift, line 66"
@Brandon-T Brandon-T added the crash label Feb 9, 2022
@Brandon-T Brandon-T added this to the 1.35.1 milestone Feb 9, 2022
@Brandon-T Brandon-T self-assigned this Feb 9, 2022
@Brandon-T Brandon-T changed the title Guard iOS 14.3 and up to be sandboxed. iOS 14.2 and below has a crash Guard iOS 14.3 and up to be sandboxed. iOS 14.2 and below has a WebKit Crash Feb 9, 2022
@Brandon-T Brandon-T removed the QA/Yes label Feb 9, 2022
@iccub iccub merged commit de006f9 into development Feb 9, 2022
@iccub iccub deleted the bugfix/iOS14.2Crash branch February 9, 2022 15:28
iccub pushed a commit that referenced this pull request Feb 9, 2022
…has a crash: "Fatal error: Bug in WebKit: Received neither result or failure.: file WebKit/WebKitSwiftOverlay.swift, line 66" (#4968)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application crash browse website
4 participants