Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #4835: Add the ability to remove site-specific web data #4836

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Jan 11, 2022

Summary of Changes

This pull request fixes #4835

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Visit websites
  • Visit Manage Website Data (Settings > Brave Shields & Privacy > Manage Website Data)
  • Verify website data appears
  • Test "Remove All"
  • Verify empty state
  • Close and re-visit websites but do something on one that saves a cookie such as login
  • Verify new data appears
  • Tap the edit button, verify that single selection changes remove button text to "Remove" and selecting more than 1 changes it to "Remove N Records" where N is the number of selected records
  • Verify tapping remove on those websites removes them from the list and refresh the web page that was logged in (or had some cookie stored) and verify you are no longer logged in (or cookie is erased)
  • Use the search functionality to limit the number of items
  • Verify tapping "Remove All" while searching only removes visible/filtered records

Screenshots:

Main Edit Mode Edit Mode Selected
main edit edit-selected
Empty State Filter
empty filter

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson force-pushed the manage-private-data branch 5 times, most recently from 49db6ec to 2a367e1 Compare January 12, 2022 23:01
@kylehickinson kylehickinson marked this pull request as ready for review January 12, 2022 23:20
@kylehickinson kylehickinson requested a review from a team January 12, 2022 23:20
@kylehickinson kylehickinson force-pushed the manage-private-data branch 2 times, most recently from 7cb7b0f to 84b62b9 Compare January 12, 2022 23:29
@kylehickinson kylehickinson added this to the 1.35 milestone Jan 13, 2022
@kylehickinson kylehickinson merged commit c9d410b into development Jan 13, 2022
@kylehickinson kylehickinson deleted the manage-private-data branch January 13, 2022 23:34
@duaneking
Copy link

Thank You!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Site-Specific Data
3 participants