Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #4244: Bump BraveCore library to 1.31.89. #4447

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Fix #4244: Bump BraveCore library to 1.31.89. #4447

merged 1 commit into from
Nov 2, 2021

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Nov 1, 2021 •
edited
Loading

Summary of Changes

This pull request fixes #4244

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.32.5 milestone Nov 1, 2021
@iccub iccub requested review from kylehickinson and a team November 1, 2021 15:54
@iccub iccub force-pushed the bugfix/4244 branch 2 times, most recently from 23e06d7 to 8dcf94c Compare November 1, 2021 16:20
@iccub iccub changed the title Fix #4244: Bump BraveCore library to 1.31.87. Fix #4244: Bump BraveCore library to 1.31.89. Nov 2, 2021
@iccub iccub merged commit 4451fa2 into development Nov 2, 2021
@iccub iccub deleted the bugfix/4244 branch November 2, 2021 14:27
@iccub iccub modified the milestones: 1.32.5, 1.33 Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.

Bump BraveCore library to 1.31.x
2 participants
@iccub @kylehickinson