This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #4335: Deprecate ours HTTPSE in favor of the one bundled in WKWeb… #4433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…View.
Summary of Changes
Security review https://github.com/brave/security/issues/640
This pull request fixes #4335
Submitter Checklist:
NSLocalizableString()
Test Plan:
Note for testers: this feature has been enabled on iOS 15 devices by default, we kept using Apple's and our implementation for some time.
This is a simple flag we turn on, we can't decide what websites are upgraded or not, we do not also know what websites we can test this on. I found apache.org to be a good candidate for testing.
Use iOS 15 device.
Enabled case:
apache.org
in url barDisabled case:
apache.org
in url barScreenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement