Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #4335: Deprecate ours HTTPSE in favor of the one bundled in WKWeb… #4433

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Nov 1, 2021

…View.

Summary of Changes

Security review https://github.com/brave/security/issues/640

This pull request fixes #4335

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Note for testers: this feature has been enabled on iOS 15 devices by default, we kept using Apple's and our implementation for some time.

This is a simple flag we turn on, we can't decide what websites are upgraded or not, we do not also know what websites we can test this on. I found apache.org to be a good candidate for testing.

Use iOS 15 device.
Enabled case:

  • Go to http://apache.org or enter apache.org in url bar
  • Verify that the website upgraded itself to https

Disabled case:

  • Go to Brave settings -> Shields and disable HTTPS upgrades
  • Go to http://apache.org or enter apache.org in url bar
  • Verify that the website did not upgrade to https

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.32.5 milestone Nov 1, 2021
@iccub iccub requested a review from a team November 1, 2021 10:15
@iccub iccub added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Nov 1, 2021
@iccub iccub removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Nov 8, 2021
@iccub iccub merged commit 181e825 into development Nov 8, 2021
@iccub iccub deleted the bugfix/4335 branch November 8, 2021 20:22
@iccub iccub modified the milestones: 1.32.5, 1.32.3 Nov 8, 2021
iccub added a commit that referenced this pull request Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate ours HTTPSE in favor of the one bundled in WKWebView
3 participants