This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #3713: Add option to drag/drop/rearrange favourites on New Tab Page Controller #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th bookmark-favourites
soner-yuksel
requested review from
kylehickinson,
nuo-xu,
Brandon-T and
iccub
and removed request for
a team
soner-yuksel
force-pushed
the
enhancement/favourite-drag-ntp
branch
from
573ddce to
0ddce89
Compare
iccub
approved these changes
Oct 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding drag and drop delegate method implementations for NewTabPageController. This will allow user to rearrange the visible favourites on NTP. Favourites outside of visible ones do not need to be handled.
Summary of Changes
This pull request fixes #3713
Submitter Checklist:
NSLocalizableString()Test Plan:
Rearrange Favourites on NTP page and check if it persists
Screenshots:
Simulator.Screen.Recording.-.iPhone.12.-.2021-10-25.at.13.05.00.mp4
Reviewer Checklist:
QA/(Yes|No)bug/enhancement