Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Bump BraveCore library to 1.30.x & move deployment target to iOS 14 #4218

Merged
merged 4 commits into from
Oct 4, 2021

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Sep 23, 2021

To be merged by rebase

Summary of Changes

This pull request fixes #4148
This pull request fixes #4107

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson added this to the 1.32 milestone Sep 23, 2021
@kylehickinson kylehickinson requested a review from a team September 23, 2021 15:22
@iccub iccub added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Sep 29, 2021
@iccub
Copy link
Contributor

iccub commented Sep 29, 2021

I put blocked label until we get new 1.30 build with the Rewards fix
#3941

@iccub iccub removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Oct 4, 2021
@iccub iccub merged commit ba72e2e into development Oct 4, 2021
@iccub iccub deleted the brave-core-1.30.x branch October 4, 2021 14:52
@iccub
Copy link
Contributor

iccub commented Oct 4, 2021

bye bye iOS 13

I updated brave-core to 1.30.88, @kylehickinson formally approved in slack

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump BraveCore library to 1.30.x Drop iOS 13 support
2 participants