Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #4071: Don't share canonical URL unless base domains differ #4072

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #4071

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Visit youtube.com directly, then visit a video from the home page. Verify that Share With… > Copy shares the watch URL
  • Go to google.com and search for something that would result in news articles appearing. Switch to the "News" tab results and select an AMP page. Verify that Share With… > Copy shares the underlying news article URL and not the Google AMP url

Screenshots

YouTube AMP
Simulator Screen Shot - iPhone 11 Pro - 2021-08-19 at 11 03 44 Simulator Screen Shot - iPhone 11 Pro - 2021-08-19 at 11 04 22

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team August 19, 2021 15:05
@kylehickinson kylehickinson added this to the 1.31 milestone Aug 19, 2021
@kylehickinson kylehickinson merged commit 6f4bc2b into development Aug 19, 2021
@kylehickinson kylehickinson deleted the single-page-sharing branch August 19, 2021 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share menu only shares the base URL
3 participants