Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #4040: Add a separate section for history items created earlier than last month #4041

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Aug 12, 2021

Right now in history list, we have sections showing items from (Today / Yesterday / Last Week / Last Month). If any item is dated before last month it is now shown in the list even it is fetched within the limits.

Adding a new section after Last Month to gather items that has older date called Earlier will be useful for some user who doesnt have many History entries.

Summary of Changes

This pull request fixes #4040

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Have History items older than 1 Month
  • Check If these items are displayed If existing time slots has less 200 items

Screenshots:

historytest21211122

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.32 milestone Aug 12, 2021
@soner-yuksel soner-yuksel requested a review from a team August 12, 2021 17:23
@soner-yuksel soner-yuksel self-assigned this Aug 12, 2021
@iccub iccub merged commit 38a1445 into development Sep 3, 2021
@iccub iccub deleted the fix/new-history-section branch September 3, 2021 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a separate section for history items created earlier than last month
3 participants