This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #4009: Disable History sync when user switches to PB only #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
reviewed
Aug 6, 2021
You are totally right, we should hide the "Delete". Change is at b944cbe |
iccub
reviewed
Aug 8, 2021
| } | ||
|
|
||
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
|
|
||
| guard !Preferences.Privacy.privateBrowsingOnly.value else { |
There was a problem hiding this comment.
convert to if this is too hard to read imo, two negations
There was a problem hiding this comment.
Actually I always try to guard the initial conditions instead of showing them inside If clause but this particular conditions, you are right it is very hard to read.
Change at 1125af9
iccub
approved these changes
Aug 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History Private Browsing Only overlay is added in case PB Only Mode is enabled.
And hiding the "Delete All" button.
Summary of Changes
This pull request fixes #4009
Submitter Checklist:
NSLocalizableString()Test Plan:
Check History When B Only mode is enabled and sync items are being seen or an overlay is hown
Screenshots:
Reviewer Checklist:
QA/(Yes|No)bug/enhancement