This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #3760 - Fix Brave-Talk and Youtube not working when tabs are switched #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
suggested changes
Jul 14, 2021
| // audio and video to stop playing, etc.. | ||
| for tab in tabManager.allTabs where tab != selected { | ||
| if let webView = tab.webView { | ||
| if #available(iOS 14.5, *) { |
There was a problem hiding this comment.
Should we add else here to always remove webview for <14.5?
soner-yuksel
approved these changes
Jul 14, 2021
iccub
approved these changes
Jul 14, 2021
iccub
changed the title
KacperWybranski
pushed a commit
to KacperWybranski/brave-ios
that referenced
this pull request
Sep 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #3760
Submitter Checklist:
NSLocalizableString()Test Plan:
Must be done on a iOS 14.5+ device
Expected: Video MUST still be playing without stopping or pausing.
--
Go to together.brave.com on computer.
Join call with “Desktop” user name or w/e.
Go to the same URL on mobile.
Join call with “Mobile” user name or w/e.
Turn on microphone on Mobile, but disable on Desktop.
Switch tabs on Mobile.
Expected: MUST still hear microphone coming from Mobile through to Desktop.
Turn on webcam on Mobile, switch tabs.
Expected: MUST see yourself on Desktop from Mobile camera even with mobile tab inactive.
Screenshots:
Reviewer Checklist:
QA/(Yes|No)bug/enhancement