This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #916: Add pull to refresh #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsxx
approved these changes
Jun 13, 2021
Brandon-T
approved these changes
Jun 14, 2021
soner-yuksel
approved these changes
Jun 21, 2021
Polydynamical
approved these changes
Jun 23, 2021
kylehickinson
force-pushed
the
pull-to-refresh
branch
from
fcac446
to
5cb54b8
Compare
|
Code changed to include settings option, so would be good to get a re-review |
soner-yuksel
reviewed
Jul 7, 2021
| @@ -548,8 +559,15 @@ class Tab: NSObject { | |||
| return | |||
| } | |||
|
|
|||
| updatePullToRefreshVisibility() | |||
There was a problem hiding this comment.
Aren't we already covering this case inside BVC preferencesDidChange ?
There was a problem hiding this comment.
No this call happens whenever a URL changes in the tab's web view (since we dont want pull to refresh on local pages at all). The BVC pref observation only ensures that it updates any visible tabs refresh control when a user flips that pref on/off
soner-yuksel
reviewed
Jul 7, 2021
| @@ -484,6 +484,9 @@ extension Strings { | |||
| public static let defaultBrowserCalloutCloseAccesabilityLabel = | |||
| NSLocalizedString("defaultBrowserCalloutCloseAccesabilityLabel", tableName: "BraveShared", | |||
| bundle: .braveShared, value: "Close default browser callout", comment: "") | |||
| public static let enablePullToRefresh = | |||
| NSLocalizedString("enablePullToRefresh", tableName: "BraveShared", | |||
| bundle: .braveShared, value: "Enable Pull-to-refresh", comment: "Describes whether or not the feature that allows the user to pull down from the top of a web page a certain amount before it triggers a page refresh") | |||
There was a problem hiding this comment.
Is this real text value? Enable Pull-to-refresh looks not matching with rest of the options because of dash usage.
iccub
approved these changes
Jul 7, 2021
KacperWybranski
pushed a commit
to KacperWybranski/brave-ios
that referenced
this pull request
Sep 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #916
Submitter Checklist:
NSLocalizableString()Test Plan:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement