Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3246: Parse page metadata correctly to ensure URL is correct #3614

Merged
merged 1 commit into from
May 5, 2021
Merged

Fix #3246: Parse page metadata correctly to ensure URL is correct #3614

merged 1 commit into from
May 5, 2021

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented May 3, 2021 •
edited by iccub
Loading

Summary of Changes

This pull request fixes #3246

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Search "Test"
  • Visit Speedtest.net result
  • Tap share and verify the URL that is shared is speedtest and not google

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team May 3, 2021 15:11
@kylehickinson kylehickinson added this to the 1.26 milestone May 3, 2021
soner-yuksel
soner-yuksel approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@soner-yuksel soner-yuksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kylehickinson kylehickinson merged commit 7f6718b into development May 5, 2021
@kylehickinson kylehickinson deleted the share-url-fix branch May 5, 2021 14:46
@srirambv srirambv mentioned this pull request May 26, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soner-yuksel soner-yuksel soner-yuksel approved these changes

@Brandon-T Brandon-T Brandon-T approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.

Shared link from different sites on the same tab is incorrect
3 participants
@kylehickinson @Brandon-T @soner-yuksel