Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3332 - Bookmarklet URLs not working properly with special characters #3349

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Feb 24, 2021

Summary of Changes

  • Fixes Bookmarklets to use the URL passed in via .bookmarkletURL or just plain URL(string: str) instead of attempting to part it as just a URL with the assumption it was already encoded properly.

This pull request fixes #3332

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Use one of examples in the ticket

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.24 milestone Feb 24, 2021
@kylehickinson kylehickinson merged commit 456b0e2 into development Feb 24, 2021
@kylehickinson kylehickinson deleted the bugfix/bookmarklet-sync-v2-regression branch February 24, 2021 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long bookmarklets are removed immediately upon saving
4 participants