This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #3334: Handle invalid VPN credentials, add 406 status code to it. #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change requested by the Guardian team.
Brandon-T
approved these changes
Feb 24, 2021
|
|
||
| } else if (statusCode == 410 || statusCode == 406) { | ||
| NSLog(@"Subscriber credential invalid: %@", subscriberCredential); | ||
| [GRDKeychain removeKeychanItemForAccount:kKeychainStr_SubscriberCredential]; |
There was a problem hiding this comment.
Can you fix the indentation here ?
soner-yuksel
approved these changes
Feb 24, 2021
kylehickinson
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change requested by the Guardian team.
Summary of Changes
This pull request fixes #3334
Submitter Checklist:
NSLocalizableString()Test Plan:
This is hard to reproduce and test properly.
Please do a simple sanity check only, see if vpn can still be purchased and if 'reset vpn configuration' works
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement