Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Bump Rewards Library to 1.19.93 #3318

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Feb 16, 2021

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson added this to the 1.24 milestone Feb 16, 2021
@kylehickinson kylehickinson requested review from Brandon-T and a team February 16, 2021 22:00
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.lock needs update?

Invalid: lock file's brave-core-ios@https://github.com/brave/brave-browser/releases/download/v1.19.89/brave-core-ios-1.19.89.tgz does not satisfy brave-core-ios@https://github.com/brave/brave-browser/releases/download/v1.19.93/brave-core-ios-1.19.93.tgz

Fixes a validation issue when submitting to the App Store
@kylehickinson kylehickinson merged commit 862f3a7 into development Feb 16, 2021
@kylehickinson kylehickinson deleted the rewards-bump-pt-2 branch February 16, 2021 23:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants