Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix#2933: Update Brave VPN intro card text + Graphic #3143

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Fix#2933: Update Brave VPN intro card text + Graphic #3143

merged 4 commits into from
Jan 12, 2021

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Dec 11, 2020 •
edited by iccub
Loading

Adding new Asset Title - Subtitle - Button Title and Graphic for VPN Intro Banner

Summary of Changes

This pull request fixes #2933

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Go to settings
  • See the intro card
  • Check Changes on the banner

Screenshots:

test33

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.23 milestone Dec 11, 2020
@soner-yuksel soner-yuksel self-assigned this Dec 11, 2020
iccub
iccub suggested changes Jan 4, 2021
View reviewed changes
BraveShared/BraveStrings.swift Outdated Show resolved Hide resolved
@kylehickinson kylehickinson removed this from the 1.23 milestone Jan 11, 2021
@iccub iccub merged commit ab0b0ff into development Jan 12, 2021
@iccub iccub deleted the vpn-banner-updates branch January 12, 2021 11:28
iccub pushed a commit that referenced this pull request Jan 12, 2021
@soner-yuksel @iccub
Fix#2933: Update Brave VPN intro card text + Graphic (#3143)
d1448da
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@Brandon-T Brandon-T Brandon-T approved these changes

@kylehickinson kylehickinson Awaiting requested review from kylehickinson

Assignees

@soner-yuksel soner-yuksel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Brave VPN intro card text + graphic
4 participants
@soner-yuksel @Brandon-T @iccub @kylehickinson