Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ref #3071: Don't use FaviconMO in fetchIcon method. Move it outside. #3096

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Ref #3071: Don't use FaviconMO in fetchIcon method. Move it outside. #3096

merged 1 commit into from
Dec 1, 2020

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Dec 1, 2020 •
edited
Loading

Summary of Changes

This pull request references #3071

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.23 milestone Dec 1, 2020
@iccub iccub requested a review from kylehickinson December 1, 2020 11:03
@iccub iccub merged commit 67eeb0d into development Dec 1, 2020
@iccub iccub deleted the bugfix/3071_2 branch December 1, 2020 15:13
@kylehickinson kylehickinson removed this from the 1.23 milestone Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soner-yuksel soner-yuksel soner-yuksel approved these changes

@Brandon-T Brandon-T Brandon-T approved these changes

@kylehickinson kylehickinson Awaiting requested review from kylehickinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iccub @Brandon-T @soner-yuksel @kylehickinson