Fix #3044: Search Suggestion Text Color blinks when text is entered

[soner-yuksel]

This PR fixes Search suggestion Text Color flickering. Re-organization will be another PR.

Summary of Changes

This pull request fixes #3044

Submitter Checklist:

• Unit Tests are updated to cover new or changed functionality
• User-facing strings use NSLocalizableString()

Test Plan:

• Load Brave Browser
• Go Settings - Search Engines - Enable Search Suggestions
• Create a new Tab and load a Webpage and press search bar
• Start typing something
• Observe Search Suggestion Boxes Text color is not flickering from blue to white

Screenshots:

Reviewer Checklist:

• Issues include necessary QA labels:
  • QA/(Yes|No)
  • release-notes/(include|exclude)
  • bug / enhancement
• Necessary security reviews have taken place.
• Adequate unit test coverage exists to prevent regressions.
• Adequate test plan exists for QA to validate (if applicable).
• Issue is assigned to a milestone (should happen at merge time).

[iccub]

Code looks good overall, I found one artifact though, happens on iOS 12, see top left in the search suggestions view, there's something blue there

[soner-yuksel]

Code looks good overall, I found one artifact though, happens on iOS 12, see top left in the search suggestions view, there's something blue there

Yeah what is that artifact let me check why it might happen.

[soner-yuksel]

Code looks good overall, I found one artifact though, happens on iOS 12, see top left in the search suggestions view, there's something blue there

iOS 12 Search Icon Artifact Problem is fixed.

[iccub]

Looks good, tested on iOS 14 and 12