This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #3071: Load favicons on background thread, fix cell reusing. #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
suggested changes
Nov 27, 2020
| }) | ||
|
|
||
| if let task = loadTaskCancellable { | ||
| DispatchQueue.global(qos: .utility).async(execute: task) |
There was a problem hiding this comment.
utility is a low priority task, something like seeing an icon may need to be bumped up to userInitiated. This also may spawn a lot of queue's on the global queue at once, are we sure we don't want to use a private NSOperationQueue instead?
Comment on lines
298
to
303
| if !shouldReuse { | ||
| return | ||
| } | ||
|
|
||
| cell.imageView?.cancelFaviconLoad() | ||
| cell.backgroundColor = .clear |
There was a problem hiding this comment.
nit: Some sort of mismatch in spacing here
There was a problem hiding this comment.
this class has a mix of 2 and 4 space format, once you approve this PR i will reformat it, don't want to add noise to the PR until then
kylehickinson
approved these changes
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #3071
Submitter Checklist:
NSLocalizableString()Test Plan:
Import large amount of bookmarks, can use file from here #3070
Scroll through bookmarks, see if there is a lag
This also fixed a bug where sometimes folder had backgrounds colors or favicons were incorrect
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement