This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix#2907: Clearing Browsing History should clear Tab History as well #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soner-yuksel
changed the title
kylehickinson
suggested changes
Nov 26, 2020
soner-yuksel
force-pushed
the
tab-history-clear
branch
from
2f2366b to
0681969
Compare
soner-yuksel
force-pushed
the
tab-history-clear
branch
from
75e231b to
bd49b3e
Compare
kylehickinson
suggested changes
Nov 27, 2020
Not Registering first entered URL problem is fixed and method is changed with "clear" Creating the security ticket for review |
iccub
approved these changes
Dec 3, 2020
kylehickinson
approved these changes
Dec 7, 2020
Brandon-T
reviewed
Dec 16, 2020
| */ | ||
| let argument: [Any] = ["_c", "lea", "r"] | ||
|
|
||
| let method = argument.compactMap { $0 as? String }.joined() |
There was a problem hiding this comment.
PR Looks good. This MIGHT not work if the optimizer is smart. If it is, this will get optimized back into a single string _clear and then get flagged by the automatic review for private methods :D
Typically I base-64 encode the string and then decode it at runtime. But for now, leave it and let's see. Just adding a comment in case it does get rekt.
There was a problem hiding this comment.
Actually I added extra obfuscation which includes base-64 encode and unicode encoding but we decided it is unnecessary.
But like you said let's see, we can put it back.
Brandon-T
approved these changes
Dec 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #2907
Security Review
https://github.com/brave/security/issues/268
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement