This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #2685: Correctly updates favorites on NTP after deletion on iPad. #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
commented
Jul 2, 2020
| @@ -30,7 +30,7 @@ class FavoritesSectionProvider: NSObject, NTPObservableSectionProvider { | |||
|
|
|||
| frc = Bookmark.frc(forFavorites: true, parentFolder: nil) | |||
| super.init() | |||
| frc.fetchRequest.fetchLimit = 6 | |||
| frc.fetchRequest.fetchLimit = 20 | |||
There was a problem hiding this comment.
I wonder if we should refetch the data after favorite update/delete.
Not a big deal, since user would have to remove 15 favs in a row to go over this fetchLimit
There was a problem hiding this comment.
Update: I added performFetch it makes sense to have it
kylehickinson
approved these changes
Jul 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #2685
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement