Fix #2155 - Clearing partial data destroys all tabs

[dvng88]

Summary of Changes

• Close tab only if Cache, Cookies and Site data option selected, for all other cases it will not close tabs.

For example,

• Cache
  Or
• Cookies and Site Data
  Result :
  Close all tabs.

This pull request fixes issue #2155

Submitter Checklist:

• Unit Tests are updated to cover new or changed functionality
• User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

• Issues include necessary QA labels:
  • QA/(Yes|No)
  • release-notes/(include|exclude)
  • bug / enhancement
• Necessary security reviews have taken place.
• Adequate unit test coverage exists to prevent regressions.
• Adequate test plan exists for QA to validate (if applicable).
• Issue is assigned to a milestone (should happen at merge time).

[iccub]

Thanks for your contribution.
We have a PR open for that ticket already #2163
Unfortunately we forgot to add assignee to that issue

Currently it's blocked as we need to discuss what's the best way to solve this and whether it is even needed

[dvng88]

Yeah so I can see in that PR, the developer has made reload for Cache/Cookies and Site Data, Where as per @srirambv comment, I have made changes.

Saved login -> All saved credentials will be lost, don't clear anything else except saved logins
Browsing history -> All browsing history will be cleared, don't clear anything else except the history
Cache/Cookie and Data -> All tabs and current sessions will be lost, for either of these two settings selected clear everything (tabs/cache/cookies/download data)and leave only saved logins intact
Download -> All download history will be lost, don't clear anything else except download data

You can decide PR basis on what expected result.

[iccub]

Yeah as I said we have triaged this issue yesterday and it needs further discussion about implementation details, we can keep both PRs and wait until some decisions are made.

ccing @Brandon-T to take over this

[iccub]

Closing, fixed here #2163