This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #1983: Always add constraints when showing reader mode bar. #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
approved these changes
Nov 20, 2019
Brandon-T
reviewed
Nov 20, 2019
| @@ -2687,6 +2682,12 @@ extension BrowserViewController { | |||
| readerModeBar.delegate = self | |||
| view.insertSubview(readerModeBar, belowSubview: header) | |||
| self.readerModeBar = readerModeBar | |||
|
|
|||
| readerModeBar.snp.makeConstraints { make in | |||
There was a problem hiding this comment.
Note: It's not actually in viewDidLayoutSubviews Github is showing it weird..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Regression caused by #1736
This pull request fixes issue #1983
Submitter Checklist:
NSLocalizableString()Test Plan:
Tap on reader mode, then on address bar again. Verify the address bar is showing
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement