This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix:#1921 Add CHANGELOG release notes for 1.13 #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhreis
added
the
blocked
|
Waiting on @kjozwiak |
kjozwiak
suggested changes
Nov 12, 2019
| - Added new preview menu on iOS13. ([#1499](https://github.com/brave/brave-ios/issues/1499)) | ||
| - Added bookmarklet support. ([#1119](https://github.com/brave/brave-ios/issues/1119)) | ||
| - Updated text size and colours on new tab stats to match desktop. ([#1641](https://github.com/brave/brave-ios/issues/1641)) | ||
| - Updated StartPage icon. ([#1598](https://github.com/brave/brave-ios/issues/1598)) |
There was a problem hiding this comment.
nit: not everyone knows that StartPage is a search engine. We should add more context. Example:
- Updated StartPage icon under search engine list.
There was a problem hiding this comment.
Startpage shows up as a quick search so dont think if it needs to be explicitly called out.
|
@srirambv mind taking a look when you have some time so we can push these to https://brave.com/latest/? |
|
Fixed. Please review and merge. Didnt change StartPage as its been there in the product already for a long time and users would know about it. |
kjozwiak
suggested changes
Nov 13, 2019
iccub
removed
the
blocked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes issue #1921
Submitter Checklist:
NSLocalizableString()Test Plan:
N/A
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement