Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1876: Revert domainUrl, add new method to strip www from url. #1879

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Nov 1, 2019

#ref 1533

Summary of Changes

This commit:
d482ffb

had a bug where domainURL wasn't stripping url parameters.
Now there are two methods, one to strip www only and leave params,
and old domainURL which keeps the scheme without params

This pull request fixes issue #1876

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@@ -238,19 +238,28 @@ extension URL {
}

/**
* Returns just the domain, but with the same scheme, and a trailing '/'.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is actually outdated, see 0158c51#diff-005e296c633487f7dcebd610aa8bdd11

@kylehickinson kylehickinson merged commit 9866737 into development Nov 2, 2019
@kylehickinson kylehickinson deleted the bugfix/1876 branch November 2, 2019 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants