This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #1876: Revert domainUrl
, add new method to strip www from url.
#1879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#ref 1533
Summary of Changes
This commit:
d482ffb
had a bug where
domainURL
wasn't stripping url parameters.Now there are two methods, one to strip
www
only and leave params,and old
domainURL
which keeps the scheme without paramsThis pull request fixes issue #1876
Submitter Checklist:
NSLocalizableString()
Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
release-notes/(include|exclude)
bug
/enhancement