Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1773: Make ad auto-dismissal time 30 seconds #1779

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Oct 23, 2019

Please use rebase merge strategy

Summary of Changes

This pull request fixes issue #1773
This pull request reverts #1703

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Go through onboarding, verify my first ad remains on screen for 30s before timing out
  • With ads enabled, browse and when an ad comes up, verify it remains on screen for 30s before timing out

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson merged commit 7411503 into development Oct 23, 2019
@kylehickinson kylehickinson deleted the ad-hanging branch October 23, 2019 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants