Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Update Rewards native libraries and add dev environment support #1761

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Oct 22, 2019

BATBraveRewardsConfiguration.default is set to dev, but for now keeping things consistent and using staging even for development builds

Summary of Changes

Updates the BraveRewards framework with the following changes from brave-core:

Full history: https://github.com/brave/brave-core/commits/master/vendor/brave-ios

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Simulator Screen Shot - iPhone 11 Pro - 2019-10-22 at 13 56 36

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

`BATBraveRewardsConfiguration.default` is set to dev, but for now keeping things consistent and using staging even for development builds
@kylehickinson kylehickinson merged commit 370f83f into development Oct 23, 2019
@kylehickinson kylehickinson deleted the dev-env branch October 23, 2019 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants