Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1689: Display the correct BAT value for one-time-tips #1701

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

kylehickinson
Copy link
Collaborator

Also fixes the duplication of "USD" in the tips list

Summary of Changes

This pull request fixes issue #1689

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Enable rewards
  • Add a recurring tip for a publisher
  • Add a one time tip for a publisher
  • Verify in the rewards settings → tips details that the list displays all BAT values as regular decimals amounts (i.e. "1.0 BAT")
  • Verify that USD is not repeated

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

Also fixes the duplication of "USD" in the tips list
@kylehickinson kylehickinson merged commit 0a173c3 into development Oct 16, 2019
@kylehickinson kylehickinson deleted the probi-tips branch October 16, 2019 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants