Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Rewards: Change Brave Ads title from "Advertisement" to "BRAVE REWARDS" #1635

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Rewards: Change Brave Ads title from "Advertisement" to "BRAVE REWARDS" #1635

merged 1 commit into from
Oct 11, 2019

Conversation

kylehickinson
Copy link
Collaborator

Fixes brave/brave-rewards-ios#243

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Enable rewards
  • See the first ad/any ad, verify top label says "BRAVE REWARDS"

Screenshots:

Simulator Screen Shot - iPhone 11 Pro - 2019-10-11 at 15 21 40

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested review from jhreis and iccub October 11, 2019 19:21
@kylehickinson kylehickinson merged commit ccb86fd into development Oct 11, 2019
@kylehickinson kylehickinson deleted the rewards-changes branch October 11, 2019 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@jhreis jhreis Awaiting requested review from jhreis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Ads Title
2 participants
@kylehickinson @iccub