Ref #1533 - Set location view text field to scheme-less domain url

[chickdan]

Summary of Changes

This pull request fixes issue #1533

This change sets the urlTextField using the domainURL. Setting it here allows for the full url to still be accessible when the user taps into the location view.

Submitter Checklist:

• Unit Tests are updated to cover new or changed functionality
• User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Shortened domainURL

Full url when location view tapped

Reviewer Checklist:

• Issues include necessary QA labels:
  • QA/(Yes|No)
  • release-notes/(include|exclude)
  • bug / enhancement
• Necessary security reviews have taken place.
• Adequate unit test coverage exists to prevent regressions.
• Adequate test plan exists for QA to validate (if applicable).
• Issue is assigned to a milestone (should happen at merge time).

[iccub]

Thanks for the contribution, the code works well :)
I'm adding blocked label, waiting on final decision from the product team

have updates from security team

[iccub]

This domainURL strips m. and mobile. schemes as well.
I talked to security team and they want to hide scheme only with www. case.

So one additional helper method needs to be added to URLExtensions.swift to remove only the www part

[chickdan]

@iccub I've pushed an update for the requested change. Please let me know if you have any suggestions for improvement.

[iccub]

All of this code is duplicated and the only difference is between "^(www)\\.", "^(www|mobile|m)\\." regexes
What do you think about some DRY refactor?

• change domainURL to a function func domainURL(stripWWWSubdomainOnly: Bool = false) -> URL
• same for normalizedHost
• in normalizedHost add something like let regex = stripWWWSubdomainOnly ? "^(www)\\." : "^(www|mobile|m)\\."
• update documentation comment in domainURL
• update testdomainURL unit test

[chickdan]

Great suggestions! I've made the requested changes and added a new unit test to account for the stripWWWSubdomainOnly parameter.

[iccub]

Great stuff, thanks :)

[iccub]

Just needs a rebase and we are good

[chickdan]

conflicts resolved :)

[iccub]

CI still failing with

/Users/travis/build/brave/brave-ios/BraveShared/Analytics/UrpService.swift:28:44: cannot call value of non-function type 'URL?'
        guard let hostUrl = try? host.asURL(), let normalizedHost = hostUrl.normalizedHost() else { return nil }