This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #1493: Themes / Dark Mode Support #1324
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "uuid": "ACE618A3-D6FC-45A4-94F2-1793C40AE927", | ||
| "title": "Default light", | ||
| "url": "www.brave.com", | ||
| "description": "The standard default light theme", | ||
| "thumbnail": "https://www.google.com", | ||
| "isDark": false, | ||
| "enabled": true, | ||
|
|
||
| "colors": { | ||
| "header": "0xf4f4f4", | ||
| "footer": "0xf8f8f8", | ||
| "home": "0xe8e8e8", | ||
| "addressBar": "0xffffff", | ||
| "border": "0x000000", | ||
| "accent": "0xfb542b", | ||
| "tints": { | ||
| "home": "0x434351", | ||
| "header": "0x434351", | ||
| "footer": "0x434351", | ||
| "addressBar": "0x434351" | ||
| }, | ||
| "transparencies": { | ||
| "addressBarAlpha": 1.0, | ||
| "borderAlpha": 0.2, | ||
| }, | ||
| "stats": { | ||
| "ads": "0xFA4214", | ||
| "trackers": "0x742BC4", | ||
| "httpse": "0x9339D4", | ||
| "timeSaved": "0x222326" | ||
| } | ||
| }, | ||
| "images": { | ||
| "header": "https://www.google.com", | ||
| "footer": "https://www.google.com", | ||
| "home": "https://www.google.com", | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
| "uuid": "B900A41F-2C02-4664-9DE4-C170956339AC", | ||
| "title": "Default dark", | ||
| "url": "www.brave.com", | ||
| "description": "The standard default dark theme", | ||
| "thumbnail": "https://www.google.com", | ||
| "isDark": true, | ||
| "enabled": true, | ||
|
|
||
| "colors": { | ||
| "header": "0x282828", | ||
| "footer": "0x282828", | ||
| "home": "0x1c1c1c", | ||
| "addressBar": "0x444444", | ||
| "border": "0xffffff", | ||
| "accent": "0xff631c", | ||
| "tints": { | ||
| "home": "0xE7E6E9", | ||
| "header": "0xE7E6E9", | ||
| "footer": "0xE7E6E9", | ||
| "addressBar": "0xE7E6E9" | ||
| }, | ||
| "transparencies": { | ||
| "addressBarAlpha": 1.0, | ||
| "borderAlpha": 0.2, | ||
| }, | ||
| "stats": { | ||
| "ads": "0xFA4214", | ||
| "trackers": "0x1bc760", | ||
| "httpse": "0x9339D4", | ||
| "timeSaved": "0xffffff" | ||
| } | ||
| }, | ||
| "images": { | ||
| "header": "https://www.google.com", | ||
| "footer": "https://www.google.com", | ||
| "home": "https://www.google.com", | ||
| } | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "uuid": "C5CB0D9A-5467-432C-AB35-1A78C55CFB41", | ||
| "title": "Default private", | ||
| "url": "www.brave.com", | ||
| "description": "The standard default private theme", | ||
| "thumbnail": "https://www.google.com", | ||
| "isDark": true, | ||
| "enabled": true, | ||
|
|
||
| "colors": { | ||
| "header": "0x1B0C32", | ||
| "footer": "0x1B0C32", | ||
| "home": "0x301B5A", | ||
| "addressBar": "0x3D2742", | ||
| "border": "0xffffff", | ||
| "accent": "0xcf68ff", | ||
| "tints": { | ||
| "home": "0xE7E6E9", | ||
| "header": "0xE7E6E9", | ||
| "footer": "0xE7E6E9", | ||
| "addressBar": "0xE7E6E9" | ||
| }, | ||
| "transparencies": { | ||
| "addressBarAlpha": 1.0, | ||
| "borderAlpha": 0.2, | ||
| }, | ||
| "stats": { | ||
| "ads": "0xFA4214", | ||
| "trackers": "0x1bc760", | ||
| "httpse": "0x9339D4", | ||
| "timeSaved": "0xffffff" | ||
| } | ||
| }, | ||
| "images": { | ||
| "header": "https://www.google.com", | ||
| "footer": "https://www.google.com", | ||
| "home": "https://www.google.com", | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember Sriram talking about changing this setting title, have we decided on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't heard anything, we're going with this for now, can adjust in future 🤷♂