This repository has been archived by the owner on May 10, 2024. It is now read-only.
Added New Private Tab QuickAction. #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
force-pushed
the
feature/QuickAction3DTouch
branch
from
8688f7d to
886dff9
Compare
iccub
suggested changes
Jul 16, 2019
Brandon-T
force-pushed
the
feature/QuickAction3DTouch
branch
2 times, most recently
from
cedb575 to
8b55dbe
Compare
danishjafri88
approved these changes
Jul 16, 2019
Brandon-T
force-pushed
the
feature/QuickAction3DTouch
branch
from
8b55dbe to
2ba9cf4
Compare
Brandon-T
force-pushed
the
feature/QuickAction3DTouch
branch
from
2ba9cf4 to
05fb4af
Compare
iccub
suggested changes
Jul 22, 2019
BraveShared/BraveStrings.swift
Outdated
| public static let QuickActionNewTab = NSLocalizedString("ShortcutItemTitleNewTab", tableName: "BraveShared", bundle: Bundle.braveShared, value: "New Tab", comment: "Quick Action for 3D-Touch on the Application Icon") | ||
|
|
||
| public static let QuickActionNewPrivateTab = NSLocalizedString("ShortcutItemTitleNewPrivateTab", tableName: "BraveShared", bundle: Bundle.braveShared, value: "New Private Tab", comment: "Quick Action for 3D-Touch on the Application Icon") | ||
|
|
iccub
approved these changes
Jul 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1258
Added New Private Tab quick action:
Quick actions are dynamic.
If the application has NEVER launched, the actions will only show "Share Brave".
However, after the first launch, the actions will depend on what mode you're browsing in:
Private Browsing Only Mode:
New Private Tab -> Launches only private tabs.
Any Other Mode:
New Tab -> Launches a regular tab.
New Private Tab -> Launches a new private tab.
Submitter Checklist:
Fix #123: This fixes the shattered coffee cup!(orNo Bug: <message>if no relevant ticket)NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement