Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Swipe gesture on bookmark hanger is difficult when its at last bookmark #953

Closed
srirambv opened this issue Mar 8, 2019 · 3 comments
Closed

Swipe gesture on bookmark hanger is difficult when its at last bookmark #953

srirambv opened this issue Mar 8, 2019 · 3 comments
Labels
bug QA/Yes release-notes/include
Milestone
1.10

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 8, 2019

Description:

Swipe gesture on bookmark hanger is difficult when its at last bookmark

Actual result:
123

Expected result:
Better handling of swipe up/down gesture on bookmark hanger

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
All

Device details:
All

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@jhreis
Copy link
Contributor

jhreis commented Mar 19, 2019 •
edited
Loading

This will all be replaced pretty soon, so going to block for now.

@jhreis jhreis added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Mar 19, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Apr 8, 2019
@iccub
Fix brave#953: Disable pan to dismiss gesture for left menu.
5f6c759 
This menu will be gone soon anyway, this is a quick fix.
@jhreis jhreis removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Apr 9, 2019
@jhreis
Copy link
Contributor

jhreis commented Apr 9, 2019

Going to allow a fix for this, and we'll re-address more fully with the new menu.

@jhreis jhreis closed this as completed in 07ebd39 Apr 9, 2019
@srirambv srirambv mentioned this issue Jun 13, 2019
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Jul 15, 2019 •
edited by kjozwiak
Loading

  • Verified passed on iPad 5th Gen (iOS 12.3.1) running 1.10 (19.07.12.14). Verified STR from description.
  • Verification PASSED on iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.16.23)

@kjozwiak kjozwiak added this to the 1.10 milestone Jul 18, 2019
@srirambv srirambv mentioned this issue Jul 29, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug QA/Yes release-notes/include
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
4 participants
@kjozwiak @jhreis @srirambv @LaurenWags