Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

App annoyances are not being sufficiently blocked #8066

Closed
iambrianfung opened this issue Sep 14, 2023 · 1 comment · Fixed by #8068
Closed

App annoyances are not being sufficiently blocked #8066

iambrianfung opened this issue Sep 14, 2023 · 1 comment · Fixed by #8068

Comments

@iambrianfung
Copy link

iambrianfung commented Sep 14, 2023

Description:

LinkedIn App notification is not being blocked/hidden when Block 'Switch to App' Notices is toggled.

This is caused by invalid selectors being sent to the script:
For linkedin

div.feed-shared-update-v2:has(span.update-components-actor__description:-abp-contains(/Anzeige|Sponsored|Promoted|Dipromosikan|Propagováno|Promoveret|Gesponsert|Promocionado|促銷內容|Post sponsorisé|프로모션|Post sponsorizzato|广告|プロモーション|Treść promowana|Patrocinado|Promovat|Продвигается|Marknadsfört|Nai-promote|ได้รับการโปรโมท|Öne çıkarılan içerik|Gepromoot|الترويج/))
div.feed-shared-update-v2:has(span.update-components-actor__sub-description:-abp-contains(/Anzeige|Sponsored|Promoted|Dipromosikan|Propagováno|Promoveret|Gesponsert|Promocionado|促銷內容|Post sponsorisé|프로모션|Post sponsorizzato|广告|プロモーション|Treść promowana|Patrocinado|Promovat|Продвигается|Marknadsfört|Nai-promote|ได้รับการโปรโมท|Öne çıkarılan içerik|Gepromoot|الترويج/))

For instagram

div[style="max-height: inherit; max-width: inherit; display: none !important;"]:has(span:-abp-contains(Paid partnership with ))
div[style="max-height: inherit; max-width: inherit; display: none !important;"]:has(span:-abp-contains(Paid partnership))
div[style="max-height: inherit; max-width: inherit;"]:has(span:-abp-contains(Paid partnership with ))

Steps to Reproduce

  1. Open Brave Browser
  2. Confirm Block 'Switch to App' Notices is toggled on
  3. Visit https://www.linkedin.com/
  4. Notice that there is banner prompt for the app
  5. Log in - notice that there is a banner prompt for the app

Actual result:

Image from iOS (2)
IMG_4319
Image from iOS (3)

Expected result:

No App Banner

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Version 1.57 (23.9.4.13)
Version 1.58 (23.8.23.22)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? Yes

Device details:

iPhone 13 Mini

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

https://bravesoftware.slack.com/archives/C3GNZANPR/p1694561748786329

Similar issue on Instagram as well
IMG_4327

@cuba cuba self-assigned this Sep 14, 2023
cuba added a commit that referenced this issue Sep 14, 2023
cuba added a commit that referenced this issue Sep 14, 2023
@iccub iccub added this to the 1.58 milestone Sep 18, 2023
iccub pushed a commit that referenced this issue Sep 18, 2023
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 Pro running iOS 17.0.3 using version 1.58 (23.10.11.20)

  • Ensured open-in-app dialogs are suppressed on sites such as reddit.com, twitter.com, linkedin.com and instagram.com
  • Ensured disabling Shields will expose the dialogs on the sites.

Shields up

Example Example Example Example
IMG_5150 IMG_5151 IMG_5152 IMG_5153

Shields down

Example Example Example
IMG_5155 IMG_5156 IMG_5157

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants