Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Small P3A Onboarding text update #8056

Closed
anthonypkeane opened this issue Sep 13, 2023 · 2 comments · Fixed by #8083
Closed

Small P3A Onboarding text update #8056

anthonypkeane opened this issue Sep 13, 2023 · 2 comments · Fixed by #8083
Assignees
@iccub
Labels
enhancement QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.58

Comments

@anthonypkeane
Copy link

anthonypkeane commented Sep 13, 2023 •
edited
Loading

Description:

Linked to #1938

Please update the word Done on the P3A screen to Continue

Question for Devs, will Start Browsing easily fit in the UI?
@iccub
Copy link
Contributor

iccub commented Sep 13, 2023

We aim to avoid long text for buttons cc @jenn-rhim

@anthonypkeane anthonypkeane added blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue and removed blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue labels Sep 14, 2023
@iccub iccub added this to the 1.58 milestone Sep 18, 2023
@iccub iccub self-assigned this Sep 18, 2023
iccub added a commit that referenced this issue Sep 18, 2023
@iccub
Fix #8056: Update P3A callout text.
b90906c
@iccub iccub mentioned this issue Sep 18, 2023
Merged
11 tasks
iccub added a commit that referenced this issue Sep 18, 2023
@iccub
Fix #8056: Update P3A callout text. (#8083)
e2b1b77
iccub added a commit that referenced this issue Sep 19, 2023
@iccub
Fix #8056: Update P3A callout text. (#8083)
c9f71f4
@hffvld
Copy link
Collaborator

hffvld commented Sep 26, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.58 (23.9.22.13)
BraveCore: 1.58.129 (117.0.5938.88)

STEPS:

  1. Fresh install and launch Brave
  2. Select Brave to be the default browser or skip it
  3. Observe Help make Brave better. screen > Verify

ACTUAL RESULTS:

  • Verified that Continue button is shown on Help make Brave better. screen
  • Verified new user can tap Continue and land on NTP
1 2
1 2

@Uni-verse Uni-verse mentioned this issue Nov 27, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@iccub
Fix brave/brave-ios#8056: Update P3A callout text. (brave/brave-ios#8083
a9bee04 
)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.58
Development

Successfully merging a pull request may close this issue.

Fix #8056: Update P3A callout text. brave/brave-ios
4 participants
@iccub @anthonypkeane @Uni-verse @hffvld