Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update Brave News opt-in card locales #7932

Closed
kylehickinson opened this issue Aug 23, 2023 · 1 comment · Fixed by #7933
Closed

Update Brave News opt-in card locales #7932

kylehickinson opened this issue Aug 23, 2023 · 1 comment · Fixed by #7933

Comments

@kylehickinson
Copy link
Collaborator

New Regions were added to Brave News: de_DE, fr_FR, en_AU, en_IN, they should be added to the list that is used to show the opt-in card for Brave News

@hffvld
Copy link
Collaborator

hffvld commented Sep 27, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.58 (23.9.26.21)
BraveCore: 1.58.129 (117.0.5938.88)

Filled issue #8167

Fresh install - PASS

STEPS:

  1. Change device language and location to de_DE
  2. Fresh install and launch Brave
  3. NTP > Verify Brave News opt-in card
  4. Enable News > Verify
  5. Repeat Steps 1 - 4 for fr_FR, en_AU and en_IN > Verify

ACTUAL RESULTS:

  • Verified that Brave News opt-in card is shown on NTP for de_DE, fr_FR, en_AU, en_IN
  • Verified that opt-in is working

de_DE fr_FR en_AU en_IN
1 2 3 4
2023-09-26_16-24-10.mp4
Upgrade install - FAIL

STEPS:

  1. Change device language and location to de_DE
  2. Fresh install build 1.57.2 and launch Brave
  3. Go through onboarding and land on NTP > Confirm that Brave News opt-in card is not shown
  4. Upgrade Brave to build 1.58 and launch it
  5. Verify if the Brave News opt-in card is shown on NTP
  6. Repeat Steps 1 - 5 for fr_FR, en_AU and en_IN > Verify the same

ACTUAL RESULTS:

  • Observed that the Brave News opt-in card is not shown on NTP after upgrade to build 1.58.

2023-09-27_13-01-10.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.