Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Close button in join native Brave Talk lobby does not work #7909

Closed
kylehickinson opened this issue Aug 21, 2023 · 2 comments · Fixed by #7910
Closed

Close button in join native Brave Talk lobby does not work #7909

kylehickinson opened this issue Aug 21, 2023 · 2 comments · Fixed by #7910
Assignees
@kylehickinson
Labels
bug Epic: Brave Talk QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.57.1

Comments

@kylehickinson
Copy link
Collaborator

Description:

If you tap the "Close" button in the native brave talk lobby (where you can enter your name and join the call) nothing happens.

Steps to Reproduce

  1. Open a Brave Talk link and load the native UI
  2. Tap the "Close" button in the top left corner

Actual result:

Nothing happens

Expected result:

Close the window

Reproduces how often:

Easily

Brave Version: 1.56+ but likely since native Talk was introduced
@kylehickinson kylehickinson self-assigned this Aug 21, 2023
kylehickinson added a commit that referenced this issue Aug 21, 2023
@kylehickinson
Fix #7909: Handle JitsiMeet delegate methods to close unjoined calls.
53a64ee 
The `ready(toClose:)` delegate method is called by the JitsiMeet SDK when you try to leave a call that hasn't officially "joined" yet. It is also called in other situations though like terminating an active call or when the connection is halted and needs to reconnect the call so we will only dismiss the `JitsiMeetView` when the user hasn't joined a call yet.
@kylehickinson kylehickinson mentioned this issue Aug 21, 2023
Merged
11 tasks
kylehickinson added a commit that referenced this issue Aug 22, 2023
@kylehickinson
Fix #7909: Handle JitsiMeet delegate methods to close unjoined calls. (…
9243b49 
…#7910)

The `ready(toClose:)` delegate method is called by the JitsiMeet SDK when you try to leave a call that hasn't officially "joined" yet. It is also called in other situations though like terminating an active call or when the connection is halted and needs to reconnect the call so we will only dismiss the `JitsiMeetView` when the user hasn't joined a call yet.
@iccub iccub added this to the 1.58 milestone Aug 23, 2023
@iccub iccub modified the milestones: 1.58, 1.57.1 Sep 13, 2023
kylehickinson added a commit that referenced this issue Sep 13, 2023
@kylehickinson
Fix #7909: Handle JitsiMeet delegate methods to close unjoined calls. (…
79d50ed 
…#7910)

The `ready(toClose:)` delegate method is called by the JitsiMeet SDK when you try to leave a call that hasn't officially "joined" yet. It is also called in other situations though like terminating an active call or when the connection is halted and needs to reconnect the call so we will only dismiss the `JitsiMeetView` when the user hasn't joined a call yet.
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.5.1 using version 1.57.1 (23.9.20.7)

  • Ensured Close button is working in the talk lobby
RPReplay_Final1695235687.mov

@hffvld
Copy link
Collaborator

hffvld commented Sep 20, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 17.0]
- iPad Air [iPadOS 16.5.1]
Brave build: 1.57.1 (23.9.20.7)
BraveCore: 1.57.53 (116.0.5845.114)

STEPS:
Followed the steps from #7909 (comment)

ACTUAL RESULTS:

  • Verified that Close button is working in native Brave Talk in the lobby.

iPhone

2023-09-20_13-03-22.mp4

iPad

2023-09-20_13-08-38.mp4

@Uni-verse Uni-verse mentioned this issue Nov 12, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7909: Handle JitsiMeet delegate methods to close …
b866a6a 
…unjoined calls. (brave/brave-ios#7910)

The `ready(toClose:)` delegate method is called by the JitsiMeet SDK when you try to leave a call that hasn't officially "joined" yet. It is also called in other situations though like terminating an active call or when the connection is halted and needs to reconnect the call so we will only dismiss the `JitsiMeetView` when the user hasn't joined a call yet.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Brave Talk QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.57.1
Development

Successfully merging a pull request may close this issue.

Fix #7909: Handle JitsiMeet delegate methods to close unjoined calls. brave/brave-ios
4 participants
@kylehickinson @iccub @Uni-verse @hffvld