Browser Lock - Cancel Issue

[soner-yuksel]

Description:

There is problem with Browser Lock screen logic reported by a user in community forums which doesnt block user from entering browser.

Community Report: https://community.brave.com/t/brave-browser-reuses-password-lock-for-opening-lock-after-accessing-passwords-cancel-button-then-unlocks-browser/501830

Steps to Reproduce

1. Make sure your Browser Lock is turned on, and access your saved passwords
2. Go to the iOS home menu, and reopen the app
3. You will now see the interface for the password lock, with the cancel button
4. Press cancel and snoop around on the person’s tabs because this browser’s lock just got bypassed

Actual result:

Cancel is presented on main browser lock

Expected result:

It should not be allowing user to cancel

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

• Can you reproduce this issue with the most recent build from TestFlight? Yes
• Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
• Can you reproduce this issue with the current build from AppStore? Yes

Device details:

Any

[hffvld]

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.6]
Brave build: 1.57 (23.8.18.20)
BraveCore: 1.57.47 (116.0.5845.96)

---

Upgrade profile - PASS

STEPS:
Followed the steps from #7893 (comment)

ACTUAL RESULTS:

• Verified that Cancel button is not shown and the user is not able to use Brave without unlocking it with a password or biometrics

---

Unlock_upgrade.mov

Fresh install - PASS

STEPS:
Followed the steps from #7893 (comment)

ACTUAL RESULTS:

• Verified that Cancel button is not shown and the user is not able to use Brave without unlocking it with a password or biometrics

---

Unlock_Fresh.mov