Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

1.51 migration crash when lot of tabs are open #7857

Closed
iccub opened this issue Aug 9, 2023 · 1 comment · Fixed by #7865
Closed

1.51 migration crash when lot of tabs are open #7857

iccub opened this issue Aug 9, 2023 · 1 comment · Fixed by #7865

Comments

@iccub
Copy link
Contributor

iccub commented Aug 9, 2023

Description:

Steps to Reproduce

  1. Install a 1.50 build.
  2. Add a lot of tabs. On dev builds go to settings and scroll down tap 'add 1000 tabs' once or twice
  3. Upgrade to 1.51 or newer

Actual result:

The app will freeze for 20 seconds then crash

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@iccub iccub added this to the 1.57 milestone Aug 10, 2023
iccub pushed a commit that referenced this issue Aug 10, 2023
… tabs (#7865)

Remove migration of screenshot data when migrating thousands of tabs
@hffvld
Copy link
Collaborator

hffvld commented Aug 22, 2023

Verified on iPhone 14using version(s):

Device/OS: iPhone 14 [iOS 16.6]
Brave build: 1.57 (23.8.18.20)
BraveCore: 1.57.47 (116.0.5845.96)

Upgrade 1.50 to 1.51 - PASS

STEPS:
Followed the steps from #7865 (comment)

ACTUAL RESULTS:

  • Verified that Brave is not freezing or crashing when a lot of tabs (1000 - 2000) are opened

1000 tabs

1000.tabs_1.50.mov

2000 tabs

2000.tabs_1.50.mov
Upgrade 1.56 to 1.57 - PASS

STEPS:
Followed the steps from #7865 (comment)

ACTUAL RESULTS:

  • Verified that Brave is not freezing or crashing when a lot of tabs (1000 - 2000) are opened

1000 tabs

1000.tabs_1.56.mov

2000 tabs

2000.tabs_1.57.mov

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
…'s thousands of tabs (brave/brave-ios#7865)

Remove migration of screenshot data when migrating thousands of tabs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.