Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Crash in BraveAds::inlineContentAdsWithDimensions #7837

Closed
aseren opened this issue Aug 7, 2023 · 1 comment · Fixed by #7884
Closed

Crash in BraveAds::inlineContentAdsWithDimensions #7837

aseren opened this issue Aug 7, 2023 · 1 comment · Fixed by #7884
Assignees
@kylehickinson
Labels
bug crash Epic: Ads QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.57

Comments

@aseren
Copy link
Collaborator

aseren commented Aug 7, 2023 •
edited
Loading

Steps to Reproduce

  • Run Brave on iOS with a fresh profile.
  • Join Brave Rewards.
  • Join Brave Today
  • Scroll a news feed until an Ad is shown

Brave Core version is 1.57.x.
The corresponding brave core issue: brave/brave-browser#32091
@aseren aseren mentioned this issue Aug 7, 2023
Closed
@kylehickinson kylehickinson mentioned this issue Aug 16, 2023
Merged
11 tasks
@kylehickinson kylehickinson added this to the 1.57 milestone Aug 16, 2023
iccub added a commit that referenced this issue Aug 16, 2023
@iccub
Fix #7837: Don't initialize ads with wallet info when rewards is not …
8334b9a 
…enabled (#7884)

Bump brave-core to 1.57.47
Co-authored-by: Kyle Hickinson <[email protected]>
@hffvld
Copy link
Collaborator

hffvld commented Aug 28, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 17.0]
- iPad Air [iPadOS 16.5.1]
Brave build: 1.57 (23.8.28.18)
BraveCore: 1.57.53 (116.0.5845.114)

STEPS:
Followed the steps from #7837 (comment)

ACTUAL RESULTS:

  • Verified that Brave is not crashing when Rewards and Brave News are enabled

iPhone

News_fixed.mov

iPad

nes_fixed_ipad_1080.mov

@Uni-verse Uni-verse mentioned this issue Nov 11, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@iccub
Fix brave/brave-ios#7837: Don't initialize ads with wallet info when …
cc4d974 
…rewards is not enabled (brave/brave-ios#7884)

Bump brave-core to 1.57.47
Co-authored-by: Kyle Hickinson <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug crash Epic: Ads QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Ref #7730: Update brave-core 1.57.47 brave/brave-ios
6 participants
@kylehickinson @iccub @Uni-verse @LaurenWags @aseren @hffvld