Restored but unopened tabs not added to Recently Closed Tabs

[StephenHeaps]

Description:

Tabs that have been restored, but not opened yet are not added to Recently Closed Tabs list when

Steps to Reproduce

1. Open 2 or more tabs
2. Fully quit Brave from app switcher
3. Open Brave
4. Tap and hold on tab tray button and tap Recently Closed Tabs
5. Clear list if not empty (not required, but easier to see bug)
6. Tap and hold on tab button, tap Close All n Tabs
7. Tap and hold on tab tray button and tap Recently Closed Tabs
8. Observe only the active tab is added

Actual result:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-04.at.16.27.54.mp4

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

• Can you reproduce this issue with the most recent build from TestFlight?
• Can you reproduce this issue with the previous version of the current build from TestFlight?
• Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

I am not overly familiar with Recently Closed Tabs code, but if I had to guess it's because the Tab url is nil in this case. You can get the url via SessionTab.from(tabId: id)?.url:
https://github.com/brave/brave-ios/blob/development/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController%2BWallet.swift#L173-L180

[hffvld]

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.57 (23.8.28.18)
BraveCore: 1.57.53 (116.0.5845.114)

---

STEPS:
Followed the steps from #7832 (comment)

ACTUAL RESULTS:

• Verified that restored but not opened yet tabs are added to Recently Closed Tabs list
• Verified that it's possible to restore tabs from Recently Closed Tabs list

---

recently.closed.mov