Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Possible duplicated auto-discovered assets after restoring wallet #7804

Closed
StephenHeaps opened this issue Jul 28, 2023 · 1 comment · Fixed by #7805
Closed

Possible duplicated auto-discovered assets after restoring wallet #7804

StephenHeaps opened this issue Jul 28, 2023 · 1 comment · Fixed by #7805

Comments

@StephenHeaps
Copy link
Contributor

Description:

Requires an account with balance on non-native assets that will be found via asset auto-discovery

Steps to Reproduce

  1. Fresh install
  2. Setup wallet with assets that get found by asset auto discovery
  3. Close wallet
  4. Open Settings -> Web3
  5. Reset Wallet
  6. Open Wallet
  7. Restore wallet from step 2

Actual result:

Assets found via auto discovery are duplicated in Portfolio, Edit User Assets, etc.

Screenshot 2023-07-28 at 3 36 06 PM Screenshot 2023-07-28 at 3 38 34 PM

Expected result:

No duplicated assets

Reproduces how often:

Not sure it occurs every time, but consistent enough to reproduce.

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@iccub iccub added this to the 1.56 milestone Jul 31, 2023
nuo-xu added a commit that referenced this issue Jul 31, 2023
…cause wallet creates duplicate auto-discovered assets (#7805)
nuo-xu added a commit that referenced this issue Jul 31, 2023
…cause wallet creates duplicate auto-discovered assets (#7805)
@srirambv
Copy link
Contributor

srirambv commented Aug 1, 2023

Verification passed on iPhone 13 with iOS 16.5 running 1.56 (23.7.31.17)

  • Verified steps from issue description
  • Verified restoring wallet doesn't duplicate tokens

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
…r` which could cause wallet creates duplicate auto-discovered assets (brave/brave-ios#7805)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.