Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Send screen always shows a different token as default selected token #7759

Closed
srirambv opened this issue Jul 20, 2023 · 1 comment · Fixed by #7763
Closed

Send screen always shows a different token as default selected token #7759

srirambv opened this issue Jul 20, 2023 · 1 comment · Fixed by #7763
Assignees
@StephenHeaps
Labels
bug Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.56

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 20, 2023 •
edited by StephenHeaps
Loading

Description:

Send screen always shows a different token as default selected token

Steps to Reproduce

prerequisite: have >1 visible asset on the currently selected network (ex. last network selected in native Buy/Send/Swap).

  1. Open Send screen
  2. Make not of the default selected send token, then close the send screen
  3. Relaunch the Send screen
  4. A different token is now shown as default selected token

Actual result:

Default.token.mp4

Expected result:

Should show the native token as default or the previous selected token as default

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Not checked
  • Can you reproduce this issue with the current build from AppStore? No

Device details:

iPad Pro (iOS 16.6 Beta)

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @StephenHeaps @nuo-xu
@srirambv srirambv mentioned this issue Jul 20, 2023
Closed
@StephenHeaps StephenHeaps self-assigned this Jul 20, 2023
@StephenHeaps StephenHeaps mentioned this issue Jul 20, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Jul 21, 2023
@StephenHeaps
Fix #7759: Send token view default token (#7763)
4aaecd7 
* Select the native asset by default, fallback to BAT token, fallback to first visible user token (sorted alphabetically)

* Auto-present Select Token to Send view when opening Send.
StephenHeaps added a commit that referenced this issue Jul 21, 2023
@StephenHeaps
Fix #7759: Send token view default token (#7763)
c59e02b 
* Select the native asset by default, fallback to BAT token, fallback to first visible user token (sorted alphabetically)

* Auto-present Select Token to Send view when opening Send.
@StephenHeaps StephenHeaps added this to the 1.56 milestone Jul 21, 2023
@srirambv
Copy link
Contributor Author

srirambv commented Aug 1, 2023

Verification passed on iPhone 13 with iOS 16.5 running 1.56 (23.7.31.17)

  • Verified steps from issue description
  • Verified Send screen retains the last selected token every time its opened until a different token is selected
7759.MP4

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7759: Send token view default token (brave/brave-…
9a3848f 
…ios#7763)

* Select the native asset by default, fallback to BAT token, fallback to first visible user token (sorted alphabetically)

* Auto-present Select Token to Send view when opening Send.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
bug Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56
Development

Successfully merging a pull request may close this issue.

Fix #7759: Send token view default token brave/brave-ios
2 participants
@StephenHeaps @srirambv