Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Reopen last closed tab in tab tray context menu #7752

Closed
StephenHeaps opened this issue Jul 19, 2023 · 1 comment · Fixed by #7789
Closed

Reopen last closed tab in tab tray context menu #7752

StephenHeaps opened this issue Jul 19, 2023 · 1 comment · Fixed by #7789

Comments

@StephenHeaps
Copy link
Contributor

Problem Description

Could we add a Reopen Last Closed Tab option to the context menu on the tap tray button? I believe we already have a re-open last closed tab hotkey, but a menu option would be nice when no hardware keyboard is connected.

We may want to make sure there is a 'last closed tab' before showing the option, similar to Duplicate Active Tab is only visible when on a webpage (not visible on new tab page).

Feature Overview

It reopens the last closed tab.

Design

IMG_555E72C35948-1

Additional information

Ref
https://bravesoftware.slack.com/archives/G01F4JUNXAQ/p1679086733461429

@hffvld
Copy link
Collaborator

hffvld commented Aug 18, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.6]
Brave build: 1.57 (23.8.16.21)
BraveCore: 1.57.47 (116.0.5845.96)

Filed follow-up issue #7897

STEPS:

  1. Fresh launch Brave
  2. Tap and hold Tab button to see the context menu > Verify
  3. Open 2 tabs > Tap and hold Tab button to see the context menu > Verify
  4. Close one tab > Tap and hold Tab button to see the context menu
  5. Tap Reopen Last Closed Tab > Verify
  6. Close both tabs one by one > Tap and hold Tab button to see the context menu
  7. Tap Reopen Last Closed Tab > Verify
  8. Tap and hold Tab button to see the context menu again > Tap Reopen Last Closed Tab > Verify

ACTUAL RESULTS:

  • Verified that Reopen Last Closed Tab is not shown when no tabs were recently closed
  • Verified that Reopen Last Closed Tab is shown when some tabs were closed already
  • Verify that it's possible to restore recently closed tabs
  • Verified that it's possible to restore more than one recently closed tab, and tabs are restored in the correct order

No recently closed tabs With recently closed tabs
1 2
1 2
Recently.closed.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants