Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Text update for the restore tabs page #7695

Closed
anthonypkeane opened this issue Jul 6, 2023 · 3 comments · Fixed by #7834 or #7949
Closed

Text update for the restore tabs page #7695

anthonypkeane opened this issue Jul 6, 2023 · 3 comments · Fixed by #7834 or #7949

Comments

@anthonypkeane
Copy link

Description:

Please update the text on this page to

Brave Closed Unexpectedly
Unfortunately, Brave crashed or did not close properly.
Restore your tabs?
Yes | No

IMG_4283

@hkarmoush
Copy link
Contributor

Only had to modify the strings inside BraveStrings.swift

@hffvld
Copy link
Collaborator

hffvld commented Aug 18, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.6]
Brave build: 1.57 (23.8.18.20)
BraveCore: 1.57.47 (116.0.5845.96)

STEPS:

  1. Launch Brave
  2. Settings > View Rewards Debug Menu > CHange Override to any other value to trigger Brave crash > Exit Now
  3. Observe the message about sharing the report > Skip it
  4. Launch Brave > Verify
  5. Tap No > Verify
  6. Trigger Restore tab page message once again > Tap Yes > Verify

ACTUAL RESULTS:

  • Verified the strings on Restore tab page message
  • Verified that the message is:
             Brave quit unexpectedly.
Unfortunately, Brave crashed or did not close properly.
               Restore your tabs?
                   No  |   Yes
  • Verified that tabs are not restored when tapped No, and tabs are restored when tapped Yes

1 2
1 2

@anthonypkeane
Copy link
Author

anthonypkeane commented Aug 21, 2023

The text on the device doesn't match the text in the issue, please look at this again

(Note: please watch for Title Case also)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.