Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Voice Search (and other onboarding popups) appear off screen when using iPad multi-tasking/split-view #7693

Closed
kylehickinson opened this issue Jul 6, 2023 · 1 comment · Fixed by #7694

Comments

@kylehickinson
Copy link
Collaborator

Description:

Anything that uses PopupViewController (such as Voice Search and some onboarding popups) would present incorrectly when using iPad and having Brave mutlitasking with any other app

Steps to Reproduce

  1. Open Brave on iPad, Tap the ••• in the center of the status bar and tap "Split View", pick any app
  2. Tap on Voice Search in the URL bar

Actual result:

Popup appears off-screen

image

Expected result:

Popup appear sized correctly inside the current available bounds

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily

@hffvld
Copy link
Collaborator

hffvld commented Jul 21, 2023

Verified on iPad Air using version(s):

Device/OS: iPad Air [iPadOS 16.5]
Brave build: 1.56 (23.7.19.18)
BraveCore: 1.56.6 (115.0.5790.90)

STEPS:

  1. Launch Brave > Tap ••• in the center of the status bar > Tap `Split View1 > Pick any app
  2. Open NTP > Tap the Microphone thumbnail in the search bar > Verify

ACTUAL RESULTS:

  • Verified that Brave Voice Search UI is shown correctly in Split screen Mode
  • Verified in Portrait Mode and Landscape Mode
  • Verified with different app proportions

1 2 3
1 2 3
4 5 6
1 2 3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.