Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add 'Media' settings section #7677

Closed
iccub opened this issue Jul 4, 2023 · 1 comment · Fixed by #7745
Closed

Add 'Media' settings section #7677

iccub opened this issue Jul 4, 2023 · 1 comment · Fixed by #7745
Assignees
@iccub
Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.56

Comments

@iccub
Copy link
Contributor

iccub commented Jul 4, 2023

No description provided.

iccub added a commit that referenced this issue Jul 18, 2023
@iccub
Fix #7677: Add 'Media' settings section.
5bb7b29
@iccub iccub mentioned this issue Jul 18, 2023
Merged
11 tasks
@iccub iccub added this to the 1.56 milestone Jul 18, 2023
iccub added a commit that referenced this issue Jul 18, 2023
@iccub
Fix #7677: Add 'Media' settings section. (#7745)
0f32f9d
iccub added a commit that referenced this issue Jul 18, 2023
@iccub
Fix #7677: Add 'Media' settings section. (#7745)
3df0b7e
@iccub iccub mentioned this issue Jul 18, 2023
Closed
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.5.1 & iPad (9th Gen) running iOS 15.5 using version 1.56 (23.7.19.18)

Fresh Profile

  • Verified Media section appears under Display in the Settings.
  • Verified Enable Background Audio is disabled by default on clean profile.
  • Verified Background audio when app is backgrounded or screen is locked when Background Audio is enabled.
  • Verified user is able to select options in the quality settings for youtube
  • Verified youtube quality settings are set to Always On by default

Existing Profile

  • Verified Background play setting preference is retained when upgrading from 1.52.1 -> 1.56
Example Example Example
IMG_3355 IMG_3356 IMG_3357
IMG_3361 IMG_3360 IMG_3358
Example Example Example
IMG_0303 3 IMG_0302 3 IMG_0301 2
IMG_0298 3 IMG_0299 3 IMG_0300 2

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@iccub
Fix brave/brave-ios#7677: Add 'Media' settings section. (brave/brave-…
647424c 
…ios#7745)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.56
Development

Successfully merging a pull request may close this issue.

Fix #7677: Add 'Media' settings section. brave/brave-ios
2 participants
@iccub @Uni-verse