Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Playlist] Not able to add an audio file to the Playlist by tapping and holding on a file #7667

Closed
hffvld opened this issue Jun 30, 2023 · 2 comments · Fixed by #7679
Closed

Comments

@hffvld
Copy link
Collaborator

hffvld commented Jun 30, 2023

Description:

Not able to add an audio file to the Playlist by tapping and holding on a file

Steps to Reproduce

  1. Launch Brave
  2. Open www.music.youtube.com
  3. Play any audio track > Tap and hold on a file similar to how you do with a video file > Observe

Actual result:

There is no option to add an audio track by tapping and holding on a file. It's working for videos only.

VIdeo

Playlist.Video.mov

Audio

Playlist.Audio.mov

Expected result:

The user must be able to save the audio file to the Playlist by tapping and holding. The same way is working for the videos.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.52 (23.6.28.13)
BraveCore: 1.52.129 (114.0.5735.198)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? Yes

Device details:

iPhone 14 [iOS 16.5]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@Brandon-T
Copy link
Collaborator

Brandon-T commented Jul 4, 2023

Technically, this is not a bug.
Audio elements don't have a width or height. What you're seeing there is a picture/thumbnail and long-pressing on it.
In other words, you're not actually touching the audio element. You're just touching the album's artwork.

In the case of Youtube though, it's also not an audio element. It's actually a video but with width = 0 and height = 0 so technically it's a video without a renderer that plays only audio lol.

In other words, this isn't supported and isn't necessary to fix because it's not actually a bug (it's intended that you can only long-press on video elements). However, I've added a PR that will fix it anyway.

@Brandon-T Brandon-T self-assigned this Jul 4, 2023
@Brandon-T Brandon-T added this to the 1.53 milestone Jul 4, 2023
iccub pushed a commit that referenced this issue Jul 6, 2023
…7679)

Fix long-press not detecting video elements of zero size.
@hffvld
Copy link
Collaborator Author

hffvld commented Jul 18, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5.1]
Brave build: 1.56 (23.7.18.21)
BraveCore: 1.56.6 (115.0.5790.90)

STEPS:

  1. Launch Brave
  2. Open www.music.youtube.com
  3. Play any audio track > Tap and hold on a file similar to how you do with a video file > Observe

ACTUAL RESULTS:

  • Verified that a user is able to save the audio file to the Playlist by tapping and holding. The same way is working for the videos.

YT.Music.mov

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
… of zero size (brave/brave-ios#7679)

Fix long-press not detecting video elements of zero size.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants